src/withdrawal: Allow deletion of withdrawal records #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When withdrawal record is deleted decrement blockedAmount of the vault, with the amount of the withdrawal
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
In case withdrawal record with status === succeeded has been deleted, vault's amount will be incremented by the withdrawal amount. For any other status blockedAmount field will be decremented
slavcho
requested changes
Dec 12, 2023
| where: { id: withdrawal.sourceVaultId }, | ||
| data: { | ||
| amount: { | ||
| increment: withdrawal.status === WithdrawStatus.succeeded ? withdrawal.amount : 0, |
There was a problem hiding this comment.
why do we have this status condition in the unit test?
Does this fluctuate?
| .catch(() => { | ||
| throw new BadRequestException("Withdrawal record couldn't be deleted") | ||
| }) | ||
|
|
There was a problem hiding this comment.
I think it is better to check the status before updating, instead of incrementing with 0...
Don't decrement blockedAmount if withdrawal status is cancelled or declined
Added test cases for deletion of withdrawal records with status cancelled,declined
slavcho
approved these changes
Dec 12, 2023
github-actions
bot
removed
the
run tests
github-actions
bot
removed
the
run tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When withdrawal record is deleted decrement blockedAmount of the vault, with the amount of the withdrawal
Closes: Reported in discord